实现对材料统计页面中的材料做初步排序。 #1510
Merged
实现对材料统计页面中的材料做初步排序。 #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightczx
requested changes
Mar 25, 2024
src/Snap.Hutao/Snap.Hutao/ViewModel/Cultivation/CultivationViewModel.cs
Outdated
Show resolved
Hide resolved
Lightczx
requested changes
Mar 27, 2024
| @@ -181,6 +181,10 @@ private async ValueTask UpdateStatisticsItemsAsync() | |||
| { | |||
| CultivationMetadataContext context = await metadataService.GetContextAsync<CultivationMetadataContext>().ConfigureAwait(false); | |||
| statistics = await cultivationService.GetStatisticsCultivateItemCollectionAsync(SelectedProject, context, token).ConfigureAwait(false); | |||
| if (statistics is not null) | |||
There was a problem hiding this comment.
既然在获取statistics后立即进行了排序，为什么没有考虑直接在Service里面排序完了再赋值呢
There was a problem hiding this comment.
不敢动，怕出现隐藏bug；此外，后续个人希望按照观测枢的数据分类再排序，这一次排序做的事就有点多了，考虑一个函数只做一件事，我就没有直接改service本身的实现，保证service的返回值是绝对原始的返回值
不过你说没问题的话，就可以改
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更细致的排序、分类功能，需要集成观测枢功能才能进行。#1427
效果图：
