Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warning: type qualifier ignored #1337

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

phcerdan
Copy link
Member

@phcerdan phcerdan commented Jul 27, 2018

Software/DGtal/DGtal-src/src/DGtal/base/OrderedAlphabet.ih:594:60: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
   ModuloComputer< Integer > mc( (const unsigned int)w.size() );
  • [NA] Unit-test of your feature with Catch.
  • [NA] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [NA] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo
Copy link
Member

thx @phcerdan
Could you please add a short entry in the changelog ?

@dcoeurjo dcoeurjo added the Build label Jul 28, 2018
@dcoeurjo dcoeurjo added this to Inbox in Issue triage via automation Jul 28, 2018
@dcoeurjo dcoeurjo added this to the 1.0 milestone Jul 28, 2018
```cpp
Software/DGtal/DGtal-src/src/DGtal/base/OrderedAlphabet.ih:594:60: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers]
   ModuloComputer< Integer > mc( (const unsigned int)w.size() );
```
@phcerdan phcerdan force-pushed the fix_type_qualifiers_ignored branch from b6900c6 to 1172ceb Compare July 28, 2018 18:27
@phcerdan
Copy link
Member Author

Added, thanks @dcoeurjo.

@dcoeurjo
Copy link
Member

Great 👍
Merging...

@dcoeurjo dcoeurjo merged commit e2f6aec into DGtal-team:master Aug 14, 2018
Issue triage automation moved this from Inbox to Done Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Issue triage
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants