square norm in pointvector #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolanddenis
reviewed
Nov 27, 2018
|
oops.. this PR also contains @JacquesOlivierLachaud's commits on #1364 |
src/DGtal/kernel/PointVector.h
Outdated
| * | ||
| * @return the square norm of the point/vector as a double. | ||
| */ | ||
| double sqnorm( ) const; |
There was a problem hiding this comment.
Is there a reason for choosing the name "sqnorm" instead of "squaredNorm" or "squaredL2Norm" ? Because it is not our usual naming conventions.
There was a problem hiding this comment.
i've seen this name in previous lib.. But I can switch to squaredNorm is you want
There was a problem hiding this comment.
squaredNorm is more homogeneous with DGtal code, but has the disadvantage to be longer (sometimes a problem for reading the code)... I let you decide.
There was a problem hiding this comment.
let's go with squaredNorm
|
All good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Checklist
cmakemode (otherwise, Travis C.I. will fail).