Specializes DigitalSurface::facesAroundVertex in the 3D case #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacquesOlivierLachaud
changed the title
dcoeurjo
reviewed
Jan 19, 2019
|
|
||
| @param order_ccw_in_3d when 'true', orders faces | ||
| counterclockwise around vertex (solely in 3d). It corresponds | ||
| to ordering the pointels counterclockwise around the given |
There was a problem hiding this comment.
counterclockwise wrt to what ?
There was a problem hiding this comment.
it means around the normal vector (I think this is the usual definition).
There was a problem hiding this comment.
I have updated the doc here and in class DigitalSurface
|
ping @JacquesOlivierLachaud , I'd like to merge this PR ;) |
JacquesOlivierLachaud
added
ready for review 👍
and removed
waiting author feedbacks
labels
|
All good. Let me see if I can fix the conflict for you... |
|
Conflict ok but I don’t know why the tests are not launched... |
|
👌 merging.thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR specializes the method DigitalSurface::facesAroundVertex in the 3D case, such that faces (ie pointels) are ordered counterclockwise with respect of the vertex (ie surfel) seen from the exterior.
Checklist
cmakemode (otherwise, Travis C.I. will fail).