Update CowPtr and Clone to fix testClone2 #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also related to #1203 |
dcoeurjo
requested changes
Jan 19, 2019
There was a problem hiding this comment.
Thanks a lot @JacquesOlivierLachaud . Just couple of typos.
JacquesOlivierLachaud
added
ready for review 👍
and removed
waiting author feedbacks
labels
rolanddenis
reviewed
Jan 25, 2019
dcoeurjo
approved these changes
Jan 26, 2019
dcoeurjo
reviewed
Jan 26, 2019
|
Travis CI errors seem not to be related to this PR. Was there a recent PR modifying the travis script ? |
|
I appends sometimes, it seems to be temporary issues with Travis... I've restarted the jobs ;) |
|
Looks ready now :-) |
rolanddenis
requested changes
Jan 30, 2019
rolanddenis
requested changes
Jan 30, 2019
rolanddenis
approved these changes
Feb 4, 2019
|
All good for me too. Thx @JacquesOlivierLachaud and @rolanddenis ! Merging (can you please close the associated Issues ?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes an issue in testClone2.cpp (and more generally in the Clone / CowPtr and CountedPtr mecanism) so that it compiles correctly both with gcc and clang (and hopefully Visual Studio).
GCC was unable to solve a construction of a CountedPtr member from a Clone parameter in an efficient way.
Related to #1381. Fix #1203.
Checklist
cmakemode (otherwise, Travis C.I. will fail).