Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug solving in obj file export: material path as a relative path #1420

Merged
merged 3 commits into from Jun 19, 2019

Conversation

jdelanoy
Copy link

@jdelanoy jdelanoy commented Jun 18, 2019

PR Description

This solves a bug in the export of OBJ meshes: the material link was written in aboslute path in the .obj file instead of relative path. This is solved by removing all the directory structure when writing the material path in the obj (will be written in the same directory).

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@JacquesOlivierLachaud
Copy link
Member

Seems fine. Do you mind updating the ChangeLog file (at the root of DGtal) ?

@dcoeurjo
Copy link
Member

  • new line in the AUTHORS file :)

@dcoeurjo
Copy link
Member

👌🎉

@dcoeurjo
Copy link
Member

thanks @jdelanoy ! Merging.

@dcoeurjo dcoeurjo merged commit 47868ad into DGtal-team:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants