Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing C++11 checks #1446

Merged
merged 10 commits into from Jan 7, 2020
Merged

Removing C++11 checks #1446

merged 10 commits into from Jan 7, 2020

Conversation

dcoeurjo
Copy link
Member

@dcoeurjo dcoeurjo commented Jan 5, 2020 •
edited

PR Description

cmake macros are used instead of the homemade checks.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Travis & appveyor)

@dcoeurjo dcoeurjo added the Build label Jan 5, 2020
@dcoeurjo dcoeurjo added this to Inbox in Issue triage via automation Jan 5, 2020
rolanddenis
rolanddenis requested changes Jan 5, 2020
View reviewed changes
Copy link
Member

@rolanddenis rolanddenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

cmake/Common.cmake Show resolved Hide resolved
cmake/DGtalConfigGenerator.cmake Show resolved Hide resolved
dcoeurjo and others added 4 commits January 5, 2020 13:35
@dcoeurjo @rolanddenis
Update cmake/Common.cmake
25c58b5 
Co-Authored-By: rolanddenis <rolanddenis@users.noreply.github.com>
@dcoeurjo @rolanddenis
Update cmake/DGtalConfigGenerator.cmake
8b47a11 
Co-Authored-By: rolanddenis <rolanddenis@users.noreply.github.com>
@dcoeurjo
Removing C++11 checks
ee87b0c
@dcoeurjo
Merge branch 'removingCPP11checks' of github.com:dcoeurjo/DGtal into …
e752886 
…removingCPP11checks
@rolanddenis
Copy link
Member

So, we also have to update DGtalTools? (cf the failing buid)

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Jan 6, 2020

Yep we should (ping @kerautret)

@kerautret
Copy link
Member

Yep we should (ping @kerautret)

Yes I look it!

@kerautret
Copy link
Member

kerautret commented Jan 6, 2020 •
edited

@dcoeurjo I think you forget to remove some lines in DGTalConfig.cmake.in , I pull request the change that should fix it (I hope):
dcoeurjo#28
And I also add a cmake check for DGtalTools:
DGtal-team/DGtalTools#364
By merging the different PR that should work 🤞🏻

@kerautret kerautret mentioned this pull request Jan 6, 2020
Merged
6 tasks
@dcoeurjo
Merge pull request #28 from kerautret/FixremovingCPP11checks
53e7ca6 
DGtalTools Fix removing cpp11checks
@dcoeurjo
Copy link
Member Author

dcoeurjo commented Jan 7, 2020

👌 thanks.

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Jan 7, 2020

it should work now.

@dcoeurjo
Copy link
Member Author

dcoeurjo commented Jan 7, 2020

All good. Thank you guys

@dcoeurjo dcoeurjo merged commit e043b0e into DGtal-team:master Jan 7, 2020
Issue triage automation moved this from Inbox to Done Jan 7, 2020
@phcerdan phcerdan mentioned this pull request Jan 9, 2020
Merged
1 task
dcoeurjo added a commit that referenced this pull request Oct 2, 2020
@dcoeurjo
Merge pull request #1446 from dcoeurjo/removingCPP11checks
ebacc60 
Removing C++11 checks
@dcoeurjo dcoeurjo deleted the removingCPP11checks branch October 7, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolanddenis rolanddenis rolanddenis approved these changes

Assignees
No one assigned
Labels
Build ready for review 👍
Projects
Issue triage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcoeurjo @rolanddenis @kerautret