Euclidean shapes csg #962
Merged
Euclidean shapes csg #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,6 +49,16 @@ | |||
| ConstIterator and adds a new method to change the color of a | |||
| specific face. (Bertrand Kerautret, | |||
| [#937](https://github.com/DGtal-team/DGtal/pull/937)) | |||
| - Refactoring of CSG operations on Euclidean / Digital shapes. | |||
| Can combine easily several operations. | |||
There was a problem hiding this comment.
Refactoring... to easily combine several operations?
|
Very nice. Could you please update the module shape documentation ?
|
|
ModuleShape documentation was updated since exampleEuclideanShapeDecorator was updated too (snipet code). But, yes, I will take advantage of this PR to improve the documentation. |
added 2 commits
March 20, 2015 16:05
added 2 commits
March 20, 2015 16:50
| @@ -54,6 +54,15 @@ | |||
| [#937](https://github.com/DGtal-team/DGtal/pull/937)) | |||
| - New methods to generate basic 3D tubular meshes and height fields. New mesh module documentation added. | |||
| (Bertrand Kerautret, [#969](https://github.com/DGtal-team/DGtal/pull/969)) | |||
| - Refactoring of CSG operations on Euclidean / Digital shapes to easily | |||
| combine easily several operations. | |||
There was a problem hiding this comment.
Yes, it's really easy.
added 2 commits
March 20, 2015 17:45
|
Thanks merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of CSG operations on Euclidean / Digital shapes.
Can combine easily several operations.
EuclideanShapesUnion, EuclideanShapesIntersection and EuclideanShapesMinus are now deprecated. Use EuclideanShapesCSG instead.
DigitalShapesUnion, DigitalShapesIntersection and DigitalShapesMinus are now deprecated. Use DigitalShapesCSG instead.