Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug reading option in volCComponentCounter #254

Merged
merged 3 commits into from
Mar 21, 2016

Conversation

kerautret
Copy link
Member

PR Description

Fix bug reading option in volCComponentCounter

Checklist

  • [n.a] Doxygen documentation of the code completed (classes, methods, types, members...)
  • [n.a] Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • [n.a] Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).

@kerautret kerautret added the bug label Mar 14, 2016
@dcoeurjo
Copy link
Member

fine for me. What was the bug you have with this tool ?

@kerautret
Copy link
Member Author

The count of Connected components looks not always good: for instance try :
bugCCCounter.vol.zip
it produce 4 cc while it looks to be 3.

@kerautret
Copy link
Member Author

@dcoeurjo perhaps I add an issue for the fix and assign to you ? ;)

@dcoeurjo
Copy link
Member

Yes, please do so

@kerautret
Copy link
Member Author

done #255
So merging thanks ;à

kerautret added a commit that referenced this pull request Mar 21, 2016
fix bug reading option in volCComponentCounter
@kerautret kerautret merged commit f58d126 into DGtal-team:master Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants