Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sdp as input for tangentBC #288

Merged
merged 7 commits into from
Feb 12, 2017
Merged

Conversation

kerautret
Copy link
Member

PR Description

tangentBC: add anoption to read sdp points as input.

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me otherwise

ChangeLog.md Outdated
@@ -26,7 +26,8 @@
- *estimators*:
- 2dlocalEstimators: add an option to export the generated contour.
(Bertrand Kerautret, [#285](https://github.com/DGtal-team/DGtalTools/pull/285))

- tangentBC: add anoption to read sdp points as input.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an option

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done thanks

@kerautret
Copy link
Member Author

and I have also added the source contour point as output (can be important when using fc)

@dcoeurjo
Copy link
Member

dcoeurjo commented Feb 8, 2017

Ok thanks. Let's wait for travis.

Are you ready for the release BTW ?

@kerautret
Copy link
Member Author

yes I have not done the DGtal doc example move (perhaps time tonight)

@kerautret
Copy link
Member Author

oups I just forget a white space in the output, I pushed it sorry for travis

@kerautret
Copy link
Member Author

fine done merging thanks

@kerautret kerautret merged commit c57ebe0 into DGtal-team:master Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants