New tool 2dCompImage #313
Merged
New tool 2dCompImage #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoeurjo
requested changes
Jan 27, 2018
doc/visualization.dox
Outdated
| @@ -19,7 +19,7 @@ | |||
| @section visualization_Doc Visualization | |||
|
|
|||
|
|
|||
|
|
|||
| - @ref Doc2dCompImage : Computes and displays image comparisons (squared and absolute differences). | |||
There was a problem hiding this comment.
Compare images and display differences (squared and absolute differences).
?
visualisation/2dCompImage.cpp
Outdated
| -e [ --imageError ] arg Output error image basename (will generate | ||
| two images <basename>MSE.ppm and | ||
| <basename>MAE.ppm). | ||
| -S [ --fixMaxColorValueMSE ] arg Fix the maximal color value for the scale |
visualisation/2dCompImage.cpp
Outdated
| getMAEstats(const Image2D & imageA, const Image2D &imageB, Image2DErr &imageMAE) | ||
| { | ||
| Statistic< int> stat(false); | ||
| for(Image2D::Domain::ConstIterator it = imageA.domain().begin(); |
There was a problem hiding this comment.
or more simply:
for(auto point: imageA.domain())
visualisation/2dCompImage.cpp
Outdated
| ("imageA,a", po::value<std::string >(), "Input filename of image A." ) | ||
| ("imageB,b", po::value<std::string >(), "Input filename of image B." ) | ||
| ("imageError,e", po::value<std::string >(), "Output error image basename (will generate two images <basename>MSE.ppm and <basename>MAE.ppm)." ) | ||
| ("fixMaxColorValueMSE,S", po::value<int>(), "Fix the maximal color value for the scale display of MSE (else the scale is set the maximal MSE value)." ) |
|
all done @dcoeurjo thanks for the review |
|
perfect. thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
New tools to compare 2D images (and visualize errors).
Checklist
cmakemode (otherwise, Travis C.I. will fail).