Vol add border interior #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoeurjo
requested changes
May 9, 2020
ChangeLog.md
Outdated
| @@ -11,6 +11,10 @@ | |||
| (Roland Denis, [#359](https://github.com/DGtal-team/DGtalTools/pull/359/files)) | |||
| - Using SourceForge to download doxygen sources during Travis CI jobs. | |||
| (Roland Denis [#360](https://github.com/DGtal-team/DGtalTools/pull/360)) | |||
| - volAddBorder: add an option to fill the border of interior volume (Bertrand | |||
There was a problem hiding this comment.
I don't understand what it means..
There was a problem hiding this comment.
in other words, it changes the image values of voxels located on the frontier of the domain.
There was a problem hiding this comment.
Is that :
Add an option that sets zero value to domain boundary voxels without changing the domain extent
?
There was a problem hiding this comment.
yes exactly, thanks I add sorry for the not clear description
dcoeurjo
requested changes
May 10, 2020
volumetric/volAddBorder.cpp
Outdated
| @@ -102,6 +102,7 @@ int main(int argc, char**argv) | |||
| general_opt.add_options() | |||
| ( "help,h", "display this message." ) | |||
| ( "input,i", po::value<std::string>(), "Input vol file." ) | |||
| ( "inside", "Add border inside the volume (set 0 inside the border)." ) | |||
There was a problem hiding this comment.
Update the option doc as well ?
There was a problem hiding this comment.
I also update the doxygen description that I forget ;)
|
Thx !;) |
dcoeurjo
approved these changes
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a small option to add border inside the volume
Checklist
cmakemode (otherwise, Travis C.I. will fail).