Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing title page and various small doc corrections. #381

Merged
merged 7 commits into from
Jul 18, 2020
Merged

Fix missing title page and various small doc corrections. #381

merged 7 commits into from
Jul 18, 2020

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Jun 14, 2020 •
edited
Loading

#312 PR Description

Fix missing title page and various small doc corrections.

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).

@kerautret kerautret changed the title Title doc Fix missing title page and various small doc corrections. Jun 14, 2020
@kerautret kerautret requested a review from dcoeurjo July 12, 2020 20:03
dcoeurjo
dcoeurjo approved these changes Jul 18, 2020
View reviewed changes
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good too thx

@dcoeurjo
Copy link
Member

Merging this one

@dcoeurjo
Copy link
Member

I don’t know why but I cannot merge this PR (from the iOS GitHub app). maybe a Travis issue ?

@kerautret
Copy link
Member Author

@dcoeurjo thanks yes probably travis is busy I reload it ;)

@kerautret
Copy link
Member Author

travis green ;) merging

@kerautret kerautret merged commit f0a8b29 into DGtal-team:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo dcoeurjo approved these changes

Assignees
No one assigned
Labels
Ready For Reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kerautret @dcoeurjo