-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #382 (3dLocalEstimators) #383
Fix issue #382 (3dLocalEstimators) #383
Conversation
👌 |
perhaps related to the version of CGAL ? I use the last one but I can try to change it with the previous one |
Ok, after my comment in the issue (#382 (comment)), I confirm that this conversion issue comes from the stricter rules in implicit conversions for |
thanks @rolanddenis you are right, the CanonicSCellEmbedder returns by definition a RealPoint: |
@dcoeurjo fixed, I follow the testMonge of DGtal, if you have time to review it is ready ;) |
I’m on it ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me. Thx
👌merging |
PR Description
Work in progress:
Checklist
cmake
mode (otherwise, Travis C.I. will fail).