Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #382 (3dLocalEstimators) #383

Merged
merged 9 commits into from
Jul 18, 2020

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Jun 14, 2020

PR Description

Work in progress:

  • ConstAlias related error
  • __ bind error:

Capture d’écran 2020-06-14 à 19 11 27

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).

@kerautret
Copy link
Member Author

Capture d’écran 2020-06-14 à 21 23 50

@dcoeurjo
Copy link
Member

👌

@kerautret
Copy link
Member Author

perhaps related to the version of CGAL ? I use the last one but I can try to change it with the previous one

@rolanddenis
Copy link
Member

Ok, after my comment in the issue (#382 (comment)), I confirm that this conversion issue comes from the stricter rules in implicit conversions for PointVector: the metric accepts integer coordinates while the embedder returns double coordinates.

@kerautret
Copy link
Member Author

kerautret commented Jun 15, 2020

thanks @rolanddenis you are right, the CanonicSCellEmbedder returns by definition a RealPoint:
https://github.com/kerautret/DGtalTools/blob/4df1f717b7d844ce6df085d2253f58938b6c87ab/estimators/3dLocalEstimators.cpp#L501-L502
Not sure to see the better alternative, perhaps @dcoeurjo could see.

@kerautret kerautret self-assigned this Jul 18, 2020
@kerautret kerautret added this to the 1.1 milestone Jul 18, 2020
@kerautret kerautret changed the title WIP: fix issue #382 (3dLocalEstimators) Fix issue #382 (3dLocalEstimators) Jul 18, 2020
@kerautret
Copy link
Member Author

@dcoeurjo fixed, I follow the testMonge of DGtal, if you have time to review it is ready ;)

@kerautret kerautret requested a review from dcoeurjo July 18, 2020 13:33
@dcoeurjo
Copy link
Member

dcoeurjo commented Jul 18, 2020

I’m on it ;)

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Thx

@dcoeurjo
Copy link
Member

👌merging

@dcoeurjo dcoeurjo merged commit 1f5968e into DGtal-team:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants