Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh viewer edit #448

Merged
merged 19 commits into from
Feb 16, 2023
Merged

Mesh viewer edit #448

merged 19 commits into from
Feb 16, 2023

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Feb 8, 2023

PR Description

-meshViewer: new options to change the default background color, to
load camera settings at startup, to change at startup the light
source mode attached or not to the camera and improve transparency
process at startup rendering. It includes a fix of the
-customColorMesh for obj mesh and add new possibilities to custom
the color of each mesh given as input. It also includes a fix and
some simplications of the option --doSnapShotAndExit.

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).
  • All continuous integration tests pass (Github Actions & appveyor).

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comment. thx

@@ -74,11 +74,13 @@ using namespace DGtal;
--SDPradius FLOAT=0.5 change the ball radius to display a set of discrete points (used with displaySDP option)
-s,--displaySDP TEXT add the display of a set of discrete points as ball of radius 0.5.
-A,--addAmbientLight FLOAT add an ambient light for better display (between 0 and 1).
-d,--doSnapShotAndExit TEXT save display snapshot into file. Notes that the camera setting is set by default according the last saved configuration (use SHIFT+Key_M to save current camera setting in the Viewer3D). If the camera setting was not saved it will use the default camera setting.
-b,--customBGColor UINT x 3 set the R, G, B, A components of the colors of the sdp view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint x3 or uint x4 ( RGB vs RGBA) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks done ;)

@dcoeurjo dcoeurjo merged commit fc743cb into DGtal-team:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants