Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge tst into main django-2.2 branch #138

Merged
merged 12 commits into from
Feb 16, 2021
Merged

Merge tst into main django-2.2 branch #138

merged 12 commits into from
Feb 16, 2021

Conversation

miggol
Copy link
Contributor

@miggol miggol commented Feb 15, 2021

This fixes #136 and updates some content and translations. Also a new banner image from the UU beeldbank is included.

(still needs testing)
Still needs testing
Decision and review listviews now sort by proposal submission date, newest first
Also added photo credits as required by UU beeldbank. Translations included.
@miggol miggol requested a review from tymees February 15, 2021 10:40
@miggol miggol changed the title Django 2.2 tst Merge tst into main django-2.2 branch Feb 15, 2021
@miggol
Copy link
Contributor Author

miggol commented Feb 15, 2021

Just realized that this should be proposal__date_submitted not date_created, will fix

It makes more sense to order by the date the proposal was submitted, otherwise a proposal that sat in draft state for a long time would unexpectedly appear at the bottom of the list
@miggol
Copy link
Contributor Author

miggol commented Feb 15, 2021

It was already different in 03bfde0 ;)

But I had accidentally ordered a poor quality version from the beeldbank, this one is nice and sharp

@tymees
Copy link
Member

tymees commented Feb 15, 2021

Oh, should've looked closer then. Oops

Currently:

date_reviewed
date_submitted_supervisor
date_submitted
date_modified
date_created

In order of relevance
@miggol miggol merged commit 5c0bdbe into django-2.2 Feb 16, 2021
@miggol miggol deleted the django-2.2-tst branch January 3, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants