Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pymysql>=1.0.0, which has a context managed connection #229

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

nickeopti
Copy link
Contributor

Closes #185, as pymysql version >=1.0 has a context managed connection. See https://github.com/PyMySQL/PyMySQL/blob/main/pymysql/connections.py#L354

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #229 (b3e659a) into main (c1c5b56) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          45       45           
  Lines        2221     2221           
  Branches      278      278           
=======================================
  Hits         2187     2187           
  Misses         19       19           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c5b56...b3e659a. Read the comment docs.

Copy link
Collaborator

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@j08lue j08lue merged commit 7d35ab8 into main Aug 6, 2021
@j08lue j08lue deleted the pymysql-version branch August 6, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pymysql 0.1.0 breaks context manager
2 participants