Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue262 #263

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Issue262 #263

merged 2 commits into from
Apr 28, 2022

Conversation

nickeopti
Copy link
Contributor

This fixes #262.

We use functionality from SQLAlchemy 1.4, and apparently ColumnCollection.values() was missing in 1.4.0, but added back in 1.4.1.

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #263 (157ba3c) into main (343a946) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   98.57%   98.76%   +0.19%     
==========================================
  Files          49       49              
  Lines        2175     2194      +19     
  Branches      304      306       +2     
==========================================
+ Hits         2144     2167      +23     
+ Misses         19       17       -2     
+ Partials       12       10       -2     
Impacted Files Coverage Δ
terracotta/exceptions.py 100.00% <0.00%> (ø)
terracotta/drivers/base_classes.py 100.00% <0.00%> (ø)
terracotta/drivers/terracotta_driver.py 100.00% <0.00%> (ø)
terracotta/drivers/sqlite_remote_meta_store.py 100.00% <0.00%> (ø)
terracotta/drivers/relational_meta_store.py 98.92% <0.00%> (+0.01%) ⬆️
terracotta/server/flask_api.py 96.20% <0.00%> (+5.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343a946...157ba3c. Read the comment docs.

@dionhaefner dionhaefner merged commit 0ed9b50 into main Apr 28, 2022
@dionhaefner dionhaefner deleted the issue262 branch April 28, 2022 09:41
@j08lue j08lue mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force newer sqlalchemy version
2 participants