Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL connection drop #267

Merged
merged 2 commits into from
May 3, 2022
Merged

Fix MySQL connection drop #267

merged 2 commits into from
May 3, 2022

Conversation

panakouris
Copy link
Contributor

This fixes #266.
Set pool_pre_ping to True when creating the sqlalchemy engine as discussed in #266

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #267 (bd13280) into main (2e8bcdb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          49       49           
  Lines        2211     2211           
  Branches      310      310           
=======================================
  Hits         2184     2184           
  Misses         17       17           
  Partials       10       10           
Impacted Files Coverage Δ
terracotta/drivers/relational_meta_store.py 98.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8bcdb...bd13280. Read the comment docs.

Co-authored-by: Dion Häfner <dion.haefner@nbi.ku.dk>
@dionhaefner dionhaefner merged commit 5cbe541 into main May 3, 2022
@dionhaefner dionhaefner deleted the issue266 branch May 3, 2022 09:41
@j08lue j08lue changed the title Issue 266 Fix MySQL connection drop May 5, 2022
@j08lue j08lue mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL - Lost connection to MySQL server during query
2 participants