Cannot copy comparer collection

[daniel-caichac-DHI]

Hi, I think this is a bug (?)
If I have a compare collection, I cannot make a copy of it :/ , but I can copy a single comparer.
Is this ok @ecomodeller ??

[jsmariegaard]

Looks like a bug 🤔

[ecomodeller]

Looks like a bug 🤔

It does.

@daniel-caichac-DHI in order to fix this properly, can you explain why you want to copy the ComparerCollection in the first place?

[daniel-caichac-DHI]

Kind of legacy code now, I might need to update it, but I was accidentally replacing the data of a comprar collection in one of my wrappers, so then I said 'of course, I first need to make a copy of the comparer collector , then I am not modifying my input anymore", and bum, crash.

As of now I added a try/expect in my wrappers, so not urgent, but thought you might want to know

[jsmariegaard]

I think it is sensible to copy a whole collection if you want to make changes to the data. It should not be necessary for filtering and analysis.

[daniel-caichac-DHI]

I had my wrappers implemented before the .query and so, but some day I should refactor my code to the new modelskill filtering implementation. Still, the .copy() should work, I reckon

[jsmariegaard]

I guess Henrik is considering whether it should be removed rather than fixed...