New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support castling move with NAG in FenParser. #12

Open

MPolleke wants to merge 2 commits into DHTMLGoodies:master from MPolleke:master

MPolleke commented Feb 16, 2021

Hi, loading a PGN with castling move with a NAG results in a hard crash on PHP 8.0.2. This PR should fix that.

PHP Error:
Fatal error: Uncaught Error: Unsupported operand types: string + int
in chessParser/FenParser0x88.php on line 1253

Sample code:

$pgn = '[Event "chessParser test"] [Site "test: Castling with NAG"] [Date "2021.02.16"] [Round "1"] [White "White player"] [Black "Black player"] [Result "*"] [PlyCount "12"] 1. e4 e5 2. d3 d6 3. Nc3 Nc6 4. Bd2 Bd7 5. Qe2 Qe7 6. O-O-O O-O-O= *';
$pgnparser = new PgnParser();
$pgnparser->setPgnContent($pgn);
$game = $pgnparser->getFirstGame();

MPolleke added 2 commits

February 16, 2021 16:15


          Support castling move with NAG in FenParser.

a73c64b


          Fix silly mistake, don't know how it got there :)

d782df9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment