-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing XMLs with integers in bases different than 10 #19
Conversation
@DHowett any review comments on this PR? Should it be accepted or rejected? What would it take to make progress here? I'm not very familiar with |
Interesting. This change absolutely makes sense. On OS X, hex int literals in plists work fine, but octal ones are ignored (treated as decimal). I'm willing to break with compatibility to support octal literals, if there's a compelling reason. If not, we should retool this so that it only switches to base 16 with the |
I don't have any reason for octal numbers support, other than it being easier to implement. I need only hex. |
That would be great! Let's stick with what OS X does. |
c9b0edc
to
a3662c6
Compare
a3662c6
to
7066d8b
Compare
Sorry for such a long delay, real life has caught up with me :-). Updated now. |
This looks great. Would you mind throwing in at least one positive and one negative decode test? |
@DHowett Updated. Let me know if there's anything else. |
Thanks a lot for contributing, and waiting, and putting up with my change requests! |
Some folks over at NetBSD like their XMLs with hex encoded integers. Since strconv parsers can derive base on their own, I think it will be best to let them do it.