Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When switching the launcher from full window to window it disappears but remains running #9

Closed
evorokk opened this issue May 18, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@evorokk
Copy link

evorokk commented May 18, 2024

Describe the bug

Initially (personally with me) launches Launcher initially in a window not on the full screen, but if you transfer the window to full windowed mode and back to windowed, the visual part disappears completely but the program remains to work (this bug appears rarely but still present and if I find out the details I will add to this post).

Steps to reproduce

  1. click on
    image
  2. click agian

Expected behavior

No response

System information

Windows 10, the latest version of the Launcher

Additional context

No response

@evorokk evorokk added the bug Something isn't working label May 18, 2024
@DIDIRUS4
Copy link
Owner

DIDIRUS4 commented Jul 1, 2024

The problem can't be reproduced :(

DIDIRUS4 pushed a commit that referenced this issue Jul 13, 2024
* Begin Work

* WIP

* WIP

* WIP

* Use error notification keys

* Finish & fix error

* Fix lint error

* Normalize message IDs (#9)

It makes sense to compose message IDs in order:
- Place (page, sub page / "modal")
- Thing
- (optionally) Relation to the thing

For example, a label for a password field would be:
- auth.sign-in (on sign-in subpage of auth)
- password (password field)
- label (is a label for the field)

Another example - button to sign in:
- auth.sign-in
- action (this is an action to do something)
- sign-in (action to sign in)

This helps keep the IDs closer to the actual structure of the page,
oftentimes smaller in the code, and easier to understand by translators.

---------

Co-authored-by: Sasha Sorokin <10401817+brawaru@users.noreply.github.com>
Co-authored-by: Prospector <6166773+Prospector@users.noreply.github.com>
@DIDIRUS4 DIDIRUS4 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants