Merge pull request #145 from DIMO-Network/chore/si-2666-add-manufactu…

…rertableset-event Chore/si 2666 add manufacturertableset event
DIMO-Network · Jun 11, 2024 · 00456cd · 00456cd
2 parents 900d40f + fde32e9
commit 00456cd
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 0 deletions.
diff --git a/contracts/implementations/tableland/DeviceDefinitionTable.sol b/contracts/implementations/tableland/DeviceDefinitionTable.sol
@@ -101,6 +101,7 @@ contract DeviceDefinitionTable is AccessControlInternal {
         dds.tables[manufacturerId] = tableId;
 
         emit DeviceDefinitionTableCreated(tableOwner, manufacturerId, tableId);
+        emit ManufacturerTableSet(manufacturerId, tableId);
     }
 
     /**
@@ -163,6 +164,7 @@ contract DeviceDefinitionTable is AccessControlInternal {
                 manufacturerIds[i],
                 tableId
             );
+            emit ManufacturerTableSet(manufacturerIds[i], tableId);
         }
     }
 

diff --git a/test/tableland/DeviceDefinitionTable.test.ts b/test/tableland/DeviceDefinitionTable.test.ts
@@ -236,6 +236,15 @@ describe('DeviceDefinitionTable', async function () {
             .to.emit(ddTableInstance, 'DeviceDefinitionTableCreated')
             .withArgs(manufacturer1.address, 1, 2);
         });
+        it('Should emit ManufacturerTableSet event with correct params', async () => {
+          await expect(
+            ddTableInstance
+              .connect(admin)
+              .createDeviceDefinitionTable(manufacturer1.address, 1)
+          )
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(1, 2);
+        });
       });
     });
 
@@ -281,6 +290,15 @@ describe('DeviceDefinitionTable', async function () {
             .to.emit(ddTableInstance, 'DeviceDefinitionTableCreated')
             .withArgs(manufacturer1.address, 1, 2);
         });
+        it('Should emit ManufacturerTableSet event with correct params', async () => {
+          await expect(
+            ddTableInstance
+              .connect(manufacturer1)
+              .createDeviceDefinitionTable(manufacturer1.address, 1)
+          )
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(1, 2);
+        });
       });
     });
   });
@@ -381,6 +399,19 @@ describe('DeviceDefinitionTable', async function () {
             .to.emit(ddTableInstance, 'DeviceDefinitionTableCreated')
             .withArgs(admin.address, 3, 4);
         });
+        it('Should emit ManufacturerTableSet event with correct params', async () => {
+          await expect(
+            ddTableInstance
+              .connect(admin)
+              .createDeviceDefinitionTableBatch(admin.address, [1, 2, 3])
+          )
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(1, 2)
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(2, 3)
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(3, 4);
+        });
       });
     });
 
@@ -460,6 +491,19 @@ describe('DeviceDefinitionTable', async function () {
             .to.emit(ddTableInstance, 'DeviceDefinitionTableCreated')
             .withArgs(manufacturerAdmin.address, 6, 4);
         });
+        it('Should emit ManufacturerTableSet event with correct params', async () => {
+          await expect(
+            ddTableInstance
+              .connect(manufacturerAdmin)
+              .createDeviceDefinitionTableBatch(manufacturerAdmin.address, [4, 5, 6])
+          )
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(4, 2)
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(5, 3)
+            .to.emit(ddTableInstance, 'ManufacturerTableSet')
+            .withArgs(6, 4);
+        });
       });
     });
   });