Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dynamic properties, stuff that isn't hashed out #107

Closed
wants to merge 2 commits into from
Closed

remove dynamic properties, stuff that isn't hashed out #107

wants to merge 2 commits into from
+0 −360

Conversation

JamesReate
Copy link
Member

@JamesReate JamesReate commented May 24, 2024 •
edited
Loading

remove:

  • attributes
  • imageUri

@JamesReate JamesReate marked this pull request as ready for review May 24, 2024 14:52
@JamesReate
Copy link
Member Author

seeing some unrelated tests fail in CI, but not locally. gqlgen was run to regen the models.

@elffjs
Copy link
Member

elffjs commented May 24, 2024

It's fine. I did some filtering.

@elffjs elffjs closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elffjs elffjs Awaiting requested review from elffjs elffjs is a code owner

@Allyson-English Allyson-English Awaiting requested review from Allyson-English Allyson-English is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamesReate @elffjs