-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SI-2707-vehicle-by-sd #109
Conversation
@Allyson-English Giving this a nudge. |
@elffjs thanks for nudging! I made those edits on friday but forgot to push them up because I got distracted by cases of if/ else for the before/ after queries. I removed the use of it here because you pointed out that it's legal but noticed that we're also doing it in these spots and was wondering if we wanted to use this opportunity to make both options allowable in those instances too: 1, 2, 3 |
That's a good catch. I can do that in another PR, no worries. I don't think it's a very useful option but unlike combining first and last it doesn't seem to do any harm. |
find vehicle a synthetic device is connected to