Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI-2707-vehicle-by-sd #109

Merged
merged 6 commits into from
Jun 17, 2024
Merged

SI-2707-vehicle-by-sd #109

merged 6 commits into from
Jun 17, 2024

Conversation

Allyson-English
Copy link
Member

find vehicle a synthetic device is connected to

Copy link

linear bot commented Jun 11, 2024

gqlgen.yml Outdated Show resolved Hide resolved
gqlgen.yml Outdated Show resolved Hide resolved
@elffjs
Copy link
Member

elffjs commented Jun 17, 2024

@Allyson-English Giving this a nudge.

@Allyson-English
Copy link
Member Author

@elffjs thanks for nudging! I made those edits on friday but forgot to push them up because I got distracted by cases of if/ else for the before/ after queries. I removed the use of it here because you pointed out that it's legal but noticed that we're also doing it in these spots and was wondering if we wanted to use this opportunity to make both options allowable in those instances too: 1, 2, 3

@elffjs
Copy link
Member

elffjs commented Jun 17, 2024

That's a good catch. I can do that in another PR, no worries.

I don't think it's a very useful option but unlike combining first and last it doesn't seem to do any harm.

@elffjs elffjs merged commit cfbd94d into main Jun 17, 2024
2 checks passed
@elffjs elffjs deleted the SI-2707-vehicle-by-sd branch June 17, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants