Update URL creation to be more robust. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJoiner
requested review from
elffjs,
Allyson-English and
0xdev22
as code owners
KevinJoiner
force-pushed
the
feature/si-2524-identity-api-image-creates-a-malformed-url
branch
from
160be5b
to
39c51d5
Compare
0xdev22
suggested changes
Mar 26, 2024
Allyson-English
approved these changes
Apr 17, 2024
* Change Url to URL in Go variables * VS Code search very bad * Even in tests xdd
elffjs
approved these changes
May 1, 2024
|
Good to merge, I think? |
elffjs
deleted the
feature/si-2524-identity-api-image-creates-a-malformed-url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.