Add handling for null earinings #92
Merged
+500
−656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering whether we should be allowing null token amounts at all in that table or in the GraphQL. I feel like it doesn't add anything. What do you think? |
elffjs
approved these changes
Apr 30, 2024
KevinJoiner
force-pushed
the
feature/si-2575-rewards-graphql-error
branch
from
39f76f0
to
dff61d4
Compare
elffjs
approved these changes
May 3, 2024
elffjs
reviewed
May 4, 2024
| SELECT 'up SQL query'; | ||
|
|
||
| ALTER TABLE rewards | ||
| ALTER COLUMN streak_earnings SET DEFAULT 0, |
There was a problem hiding this comment.
Ah crap I think you need to still do an UPDATE rewards …. Trying to patch this up.
elffjs
reviewed
May 4, 2024
| @@ -0,0 +1,25 @@ | |||
| -- +goose Up | |||
There was a problem hiding this comment.
Oh one more thing—we try to name this sequentially. I think goose has a command that helps you do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 related issues.
Our schema has fields with type
BigInt!which maps to the go type *BigInt if we return a nil value GQL returns the errorthe requested element is null which the schema does not allow.We had checks for TotalSum being 0, which prevented us from returning other relevant information, such as totalCount.
Our SUM for calculating TotalTokens was adding cols that could be
NULL. Unlike the SUM function if you call operators like+onNuLLthey will always returnNULL.