-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v6r14] Enable Coveralls and Landscape #2925
Conversation
Thanks, I've just done what you asked. |
Review OK. |
Added also landscape. Go to landscape.io and link github repo, afterwards it runs on every merge/push, by default it picks up .pylintrc |
Just one additional comment, I think it is actually better to run pylint via landscape rather than as a standalone test, since given the current situation, such a test would always fail |
And also you get a diff on the consecutive pylints, meaning that you will see what are errors introduced and fixed. |
Enabled landscape.io too |
Changes Unknown when pulling b6e6d0b on petricm:newTests into * on DIRACGrid:rel-v6r14*. |
|
are the mail notifications mandatory ? |
I think yes, since the landscape-bot sends a mail to display the information in the conversation and you receive all things from the conversation. I agree that this is annoying, but can be easily filtered. |
Use Coveralls for coverage.
Go to https://coveralls.io/ and link DIRACGrid to coveralls and enable coveralls for the DIRAC and Pilot (I will do it later) repos.
I have already formed the badge to point to the right place.