Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6r14] Enable Coveralls and Landscape #2925

Merged
merged 5 commits into from
May 20, 2016
Merged

Conversation

petricm
Copy link

@petricm petricm commented May 18, 2016

Use Coveralls for coverage.

Go to https://coveralls.io/ and link DIRACGrid to coveralls and enable coveralls for the DIRAC and Pilot (I will do it later) repos.

I have already formed the badge to point to the right place.

@petricm petricm changed the title New tests [v6r14] Enable Coveralls May 18, 2016
@fstagni
Copy link
Contributor

fstagni commented May 18, 2016

Thanks, I've just done what you asked.

@fstagni
Copy link
Contributor

fstagni commented May 18, 2016

Review OK.

@petricm petricm changed the title [v6r14] Enable Coveralls [v6r14] Enable Coveralls and Landscape May 18, 2016
@petricm
Copy link
Author

petricm commented May 18, 2016

Added also landscape. Go to landscape.io and link github repo, afterwards it runs on every merge/push, by default it picks up .pylintrc

@petricm
Copy link
Author

petricm commented May 18, 2016

Just one additional comment, I think it is actually better to run pylint via landscape rather than as a standalone test, since given the current situation, such a test would always fail

@petricm
Copy link
Author

petricm commented May 18, 2016

And also you get a diff on the consecutive pylints, meaning that you will see what are errors introduced and fixed.

@fstagni
Copy link
Contributor

fstagni commented May 18, 2016

Enabled landscape.io too

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b6e6d0b on petricm:newTests into * on DIRACGrid:rel-v6r14*.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.00% when pulling b6e6d0b on petricm:newTests into 1a4e8f2 on DIRACGrid:master.

@chaen
Copy link
Contributor

chaen commented May 18, 2016

are the mail notifications mandatory ?

@petricm
Copy link
Author

petricm commented May 18, 2016

I think yes, since the landscape-bot sends a mail to display the information in the conversation and you receive all things from the conversation. I agree that this is annoying, but can be easily filtered.

@atsareg atsareg merged commit 391bd8c into DIRACGrid:rel-v6r14 May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants