Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v6r14] Fix CPU normalization and few changes in RemoveReplica #2933

Merged
merged 10 commits into from
Jun 2, 2016
Merged

[v6r14] Fix CPU normalization and few changes in RemoveReplica #2933

merged 10 commits into from
Jun 2, 2016

Conversation

phicharp
Copy link
Contributor

@phicharp phicharp commented May 24, 2016 •
edited

RemoveReplica:

  • Some cosmetics
  • bulkRemoval() was modifying its input dict argument and returning it: useless, only modify argument

CPUNormalization:

  • Get HS06 from JOBFEATURES if present

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 11.945% when pulling d20df13 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.01% when pulling d20df13 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 11.944% when pulling 1a46c4a on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@chaen
Copy link
Contributor

chaen commented May 25, 2016

From the pure logic point of view, review OK, however landscape found new small style errors which I would encourage to correct (number of indent space and things like this)

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.01% when pulling 1a46c4a on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.00% when pulling 998fde1 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 11.95% when pulling 998fde1 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.01% when pulling 294b5bc on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.01% when pulling 294b5bc on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 11.954% when pulling 294b5bc on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 11.937% when pulling 059f830 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

andresailer
andresailer reviewed May 25, 2016
View reviewed changes
DataManagementSystem/Agent/RequestOperations/RemoveReplica.py

def singleRemoval( self, opFile, targetSE ):
""" remove opFile replica from targetSE
def removeWithOwnerProxy( self, opFile, targetSE ):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this is a change of an interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, indeed these methods should not be public!!! but this is the case of a large fraction of methods and 90% of data members of our classes...
I can change that indeed! ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just mark it as _removeWithOwnerProxy

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 11.954% when pulling 8864dc3 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.00% when pulling 8864dc3 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 11.943% when pulling af42f2e on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.00% when pulling af42f2e on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 11.949% when pulling eee8be9 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@landscape-bot
Copy link

Code Health
Repository health increased by 0.00% when pulling eee8be9 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 11.95% when pulling a3a2df5 on phicharp:v6r14-PhC-160524 into 391bd8c on DIRACGrid:rel-v6r14.

@chaen
Copy link
Contributor

chaen commented May 30, 2016

Review OK

@atsareg atsareg merged commit f2792f9 into DIRACGrid:rel-v6r14 Jun 2, 2016
@phicharp phicharp deleted the v6r14-PhC-160524 branch October 28, 2016 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@phicharp @coveralls @landscape-bot @chaen @fstagni @andresailer @atsareg