[v6r21] Add DN list from lhcb_pilot group to json file #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkrzemien
changed the title
fstagni
reviewed
Apr 4, 2019
WorkloadManagementSystem/Utilities/PilotCStoJSONSynchronizer.py
Outdated
Show resolved
Hide resolved
fstagni
previously approved these changes
Apr 4, 2019
andresailer
reviewed
Apr 4, 2019
WorkloadManagementSystem/Utilities/PilotCStoJSONSynchronizer.py
Outdated
Show resolved
Hide resolved
|
This is an LHCb specific fix. To make it generic, one should go through the Operations section and look up for all the Pilot sections and GenericPilotDN option inside them |
Replace by generic option.
|
Ok. I change it according to the suggestion. I hope it is fine now. |
fstagni
reviewed
Apr 9, 2019
WorkloadManagementSystem/Utilities/PilotCStoJSONSynchronizer.py
Outdated
Show resolved
Hide resolved
fstagni
reviewed
Apr 9, 2019
| @@ -171,6 +170,20 @@ def _getCSDict(self): | |||
|
|
|||
| return pilotDict | |||
|
|
|||
| def _getDNs(self, certGroupName): | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
If not, please anyway update that module, do not add generic functions to this one. And possibly port the test you did here, to there.
There was a problem hiding this comment.
Yes, seems the same. The whole function is not needed anyway since it is not used anymore, so I removed it.
|
just fix the format to make pycodestyle happy. |
|
Damm sorry. Let's see if it is fine now. |
fstagni
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
WorkloadManagementSystem
CHANGE: Modification of utility function PilotCStoJSONSynchronizer. The modification allows to add information to created json file about the DNs fields of users belonging to 'lhcb_pilot' group. This information is needed for the second level authorization used in the Pilot Logger architecture.
Also, some basic unit tests are added.
ENDRELEASENOTES