[v7r1] FTS3: allow to alter TPC preference list and source SE with plugins #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaen
force-pushed
the
rel-v7r1_FEAT_fts3ProtoPlugin
branch
from
32c0485
to
4b0d4dc
Compare
andresailer
reviewed
Apr 13, 2021
andresailer
reviewed
Apr 13, 2021
|
Ah, this bloody VO parameter... OK, I'll try to cook up something. But that basically means that the initialization done can only be VO agnostic. I'll modify accordingly, thanks for the review |
|
@andresailer I changed the implementation, it should now propagate the |
andresailer
reviewed
Apr 13, 2021
andresailer
previously approved these changes
Apr 14, 2021
chaen
force-pushed
the
rel-v7r1_FEAT_fts3ProtoPlugin
branch
from
3592e47
to
8dac8ca
Compare
|
Thanks for the very careful review. I've just squashed all the commit together, and it runs fine in LHCb. Please re-approve, I'll remove the WIP |
chaen
changed the title
andresailer
approved these changes
Apr 14, 2021
atsareg
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some links may be special or some sites shitty, this mechanism allows for more flexibility in choosing a third party protocol or a source SE when transferring with FTS.
This comes with a Default plugin which does exactly what the hardcoded behavior was doing, and serves as documentation. It is totally backward compatible.
This is currently tested in LHCb
BEGINRELEASENOTES
*Subsystem
NEW: FTS3 plugins to alter TPC and source SE preferences
ENDRELEASENOTES