Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.0] Replace ROOT_All with ROOT #7561

Merged
merged 1 commit into from Apr 10, 2024
Merged

Conversation

chrisburr
Copy link
Member

Apparently ROOT_All was to indicate the file was for use with POOL and apparently this only matters for LHCb. As we only need ROOT these days and the default causes problems the simplest thing is to just change it.

BEGINRELEASENOTES

*Core
CHANGE: Replace the default PFN type ROOT_All with ROOT

ENDRELEASENOTES

@chrisburr chrisburr requested a review from fstagni April 10, 2024 08:05
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Apr 10, 2024
@fstagni fstagni merged commit a2785d8 into DIRACGrid:rel-v8r0 Apr 10, 2024
25 checks passed
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Apr 10, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/8629415183

Failed:

  • integration
    cherry-pick a2785d8 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-a2785d8b1-integration
    git cherry-pick -x -m 1 a2785d8b1
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #7561 Replace ROOT_All with ROOT' --author='Chris Burr <christopher.burr@cern.ch>'
    git push -u origin cherry-pick-2-a2785d8b1-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] Replace ROOT_All with ROOT' \
         --body 'Sweep #7561 `Replace ROOT_All with ROOT` to `integration`.
    
    Adding original author @chrisburr as watcher.
    
    BEGINRELEASENOTES
    
    *Core
    CHANGE: Replace the default PFN type ROOT_All with ROOT
    
    ENDRELEASENOTES
    Closes #7562'

@chrisburr chrisburr deleted the bye-bye-pool branch April 12, 2024 21:07
chrisburr added a commit to chrisburr/DIRAC that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants