Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0] Running webapp without using nginx #699

Merged
merged 1 commit into from Dec 15, 2022
Merged

[5.0] Running webapp without using nginx #699

merged 1 commit into from Dec 15, 2022

Conversation

chrisburr
Copy link
Member

Leaving as draft as this needs to be thought about carefully.

BEGINRELEASENOTES

FIX: Running webapp without using nginx

ENDRELEASENOTES

@chrisburr chrisburr mentioned this pull request Oct 17, 2022
Closed
@chrisburr chrisburr requested review from sfayer and removed request for sfayer October 20, 2022 10:53
@chaen
Copy link
Contributor

chaen commented Nov 25, 2022

seems ok to me

@chrisburr chrisburr marked this pull request as ready for review November 25, 2022 13:45
@fstagni
Copy link
Contributor

fstagni commented Nov 25, 2022

Well, this is something that we said to "maybe not merge" at BiLD meetings. Opinion?

@chaen
Copy link
Contributor

chaen commented Nov 25, 2022

why not ? And what would the solution be then ?

@fstagni
Copy link
Contributor

fstagni commented Nov 25, 2022

The solution would be "install nginx", at least for production setup. For testing it would be useful...

Anyway, @chrisburr was not sure about the correctness of this one.

@chaen
Copy link
Contributor

chaen commented Nov 28, 2022

I see.
Well, we can definitely recommend to have nginx for production setup, but I can't think of anything wrong with this patch

@marianne013
Copy link

Would we be able to put that in the next release ? Judging from Luisa's comments CTA also runs without nginx.
We are currently running off this branch, but it's not a permanent solution, especially if Janusz gets creative :-D

@chrisburr chrisburr merged commit da55aa9 into DIRACGrid:rel-v5r0 Dec 15, 2022
@chrisburr chrisburr deleted the fix-without-nginx branch December 15, 2022 09:49
@chrisburr chrisburr restored the fix-without-nginx branch December 15, 2022 09:50
@DIRACGridBot DIRACGridBot mentioned this pull request Dec 15, 2022
Merged
DIRACGridBot pushed a commit to DIRACGridBot/WebAppDIRAC that referenced this pull request Dec 15, 2022
@chrisburr @web-flow
sweep: DIRACGrid#699 Running webapp without using nginx
c541ac7
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/WebAppDIRAC/actions/runs/3702934353

Successful:

  • integration

@chrisburr chrisburr deleted the fix-without-nginx branch January 11, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaen chaen chaen approved these changes

Assignees

@sfayer sfayer

Labels
alsoTargeting:integration sweep:done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@chrisburr @chaen @fstagni @marianne013 @DIRACGridBot @sfayer