Add pre commit configuration and drop support for Python < 3.9 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
force-pushed
the
add-pre-commit
branch
from
c933dff
to
f683eeb
Compare
chrisburr
changed the title
chrisburr
force-pushed
the
add-pre-commit
branch
from
f683eeb
to
95f8fd9
Compare
chrisburr
force-pushed
the
add-pre-commit
branch
from
d69e9d4
to
95f8fd9
Compare
chrisburr
force-pushed
the
add-pre-commit
branch
from
d69e9d4
to
224e460
Compare
fstagni
reviewed
Feb 14, 2023
| if: github.event_name != 'push' || github.repository == 'DIRACGrid/diraccfg' | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-python@v2 |
fstagni
reviewed
Feb 14, 2023
| assert "Failed to parse" in stderr | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
Are these tests still needed?
|
You might also want to update the README |
|
I've updated the README but I propose to do the other comments in a smaller PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.