Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid hyphens in values.yaml before it is too much used #105

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: avoid hyphens in values.yaml before it is too much used #105

merged 1 commit into from
Jun 25, 2024

Conversation

aldbr
Copy link
Contributor

@aldbr aldbr commented Jun 24, 2024

Closes #83

From what I understand:

  • chart dependencies should be defined with hyphens
  • values from values.yaml should be defined in camel case

I am not sure how values from chart dependencies should be named in values.yaml (e.g. opentelemetry-collector).

@aldbr aldbr marked this pull request as ready for review June 24, 2024 08:12
@aldbr aldbr mentioned this pull request Jun 24, 2024
Open
@chrisburr chrisburr merged commit a03d259 into DIRACGrid:master Jun 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid values with hyphens
2 participants
@aldbr @chrisburr