Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when host is running in low resolution (Windows only) #289

Closed
lucianoiam opened this issue Jun 15, 2021 · 4 comments
Closed

Issue when host is running in low resolution (Windows only) #289

lucianoiam opened this issue Jun 15, 2021 · 4 comments

Comments

@lucianoiam
Copy link
Contributor

lucianoiam commented Jun 15, 2021

Steps to reproduce (valid for current develop 92f0f97)

  1. Compile examples
  2. Right click on desktop -> Display Settings -> Scale and Layout -> Change the size of text, apps and other items -> 150%
  3. Start a non-DPI aware host (like Live 10.1.5). It should look a bit blurry due to scaling.
  4. Insert d_Parameters VST

Expected result:

  • Host window remains unaffected

Actual result:

  • Host window breaks

Background: on a small 13" 1080p screen system scaling comes handy; older apps look blurry but that's preferable to having microscopic text.

Looks like loading the plugin forces the host to "convert" into a DPI-aware process with unpredictable results due to pugl calling SetProcessDPIAware() (exact line here). Maybe it's a bit of an edge case but it wasn't happening a couple of weeks ago. If I correctly recall on earlier DPF versions the plugin just stayed lo-res (blurry) following the parent process configuration.

Probably that call should be issued only when running standalone and skip it for plugins?. Now I think any call that may have an effect on the process should be omitted when running as plugin.

Note on the attachment: it was shot via Remote Desktop but that does not affect the experiment, using a physical display leads to the same result.

dpf_hidpi.mov
@falkTX
Copy link
Contributor

falkTX commented Jun 15, 2021

very interesting, I was not aware this could even happen!
I will report the issue upstream.

@falkTX
Copy link
Contributor

falkTX commented Jun 15, 2021

Older versions of DPF used a very old pugl. As of last month I updated to latest upstream.

Can you confirm that removing SetProcessDPIAware fixes this issue?

@lucianoiam
Copy link
Contributor Author

Makes sense. Yes, removing SetProcessDPIAware fixes the issue.

falkTX added a commit that referenced this issue Jul 2, 2021
Fixes #289

Signed-off-by: falkTX <falktx@falktx.com>
@falkTX
Copy link
Contributor

falkTX commented Jul 2, 2021

Now fixed, patch submitted upstream at lv2/pugl#55

@falkTX falkTX closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants