Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to GCC10 for better C++2a support #67

Open
AeroStun opened this issue May 15, 2020 · 5 comments
Open

Upgrade to GCC10 for better C++2a support #67

AeroStun opened this issue May 15, 2020 · 5 comments
Assignees
@AeroStun
Labels
deferred More work will be done at a later stage extra Stuff that would be nice to have but is not required

Comments

@AeroStun
Copy link
Contributor

AeroStun commented May 15, 2020 •
edited
Loading

See <compare> and <span>

Acceptance criteria: Use three-way comparison and std::span, as well the obvious CI GCC upgrade
@AeroStun AeroStun added extra Stuff that would be nice to have but is not required sprint-6 User stories & bugs for TBD on sprint 6 labels May 15, 2020
@AeroStun AeroStun self-assigned this May 15, 2020
@RuthgerD RuthgerD mentioned this issue May 20, 2020
Merged
@platisd
Copy link
Collaborator

platisd commented May 20, 2020

I was trying to use std::span with GCC 9.2 and it wouldn't be there. Good to know it came with GCC 10. I was waiting for it! 🎉

@AeroStun
Copy link
Contributor Author

https://en.cppreference.com/w/cpp/compiler_support

GNU libstdc++ with GCC10, LLVM libc++ with Clang/LLVM7, MS STL with MSVC19.26, AppleClang libc++ with XCode10

Technically we already use the pre-c++2a gsl::span, so that transition will be seamless for us

@platisd
Copy link
Collaborator

platisd commented May 20, 2020

Were you using Microsoft's implementation for GSL?

@AeroStun
Copy link
Contributor Author

Correct; however I mostly included the GSL for the its general purpose: a support library for the CppCoreGuidelines
If you're looking for a portable way to have spans in any ISO C++ version, I can recommend span_lite

@platisd
Copy link
Collaborator

platisd commented May 20, 2020

Correct; however I mostly included the GSL for the its general purpose: a support library for the CppCoreGuidelines
If you're looking for a portable way to have spans in any ISO C++ version, I can recommend span_lite

That's exactly what I was after, thanks! 👍

@AeroStun AeroStun added deferred More work will be done at a later stage and removed sprint-6 User stories & bugs for TBD on sprint 6 labels May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AeroStun AeroStun

Labels
deferred More work will be done at a later stage extra Stuff that would be nice to have but is not required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@platisd @AeroStun