Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete buggy smoothScroll #777

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Yuki-Nagato
Copy link

No description provided.

@liuly0322
Copy link

liuly0322 commented Mar 12, 2024

Chrome may render a different border width with different zoom level, so it's better not to use 33px, use scrollIntoView instead liuly0322/aplayer-ts@7ff6882

image

ref: https://stackoverflow.com/questions/49157915/how-to-make-sure-the-1px-border-always-show-up-regardless-how-much-the-user-zoom

Edit: scrollIntoView sometimes scroll the whole page. Set block: 'nearest', or instead use: template.listOl.scrollTop = currentListItem.offsetTop and set listOl.position = 'relative' https://stackoverflow.com/questions/11039885/scrollintoview-causing-the-whole-page-to-move

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants