fix: use PUPPETEER_SKIP_DOWNLOAD

ref: puppeteer/puppeteer#10054

.github/workflows/docker-release.yml

@@ -112,7 +112,7 @@ jobs:
         uses: docker/build-push-action@v4
         with:
           context: .
-          build-args: PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=0
+          build-args: PUPPETEER_SKIP_DOWNLOAD=0
           push: true
           tags: ${{ steps.meta-chromium-bundled.outputs.tags }}
           labels: ${{ steps.meta-chromium-bundled.outputs.labels }}

.github/workflows/docker-test.yml

@@ -49,7 +49,7 @@ jobs:
         uses: docker/build-push-action@v4
         with:
           context: .
-          build-args: PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=0  # also test bundling Chromium
+          build-args: PUPPETEER_SKIP_DOWNLOAD=0  # also test bundling Chromium
           load: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}

Dockerfile

@@ -20,7 +20,7 @@ COPY ./package.json /app/
 # lazy install Chromium to avoid cache miss, only install production dependencies to minimize the image size
 RUN \
     set -ex && \
-    export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true && \
+    export PUPPETEER_SKIP_DOWNLOAD=true && \
     yarn install --production --frozen-lockfile --network-timeout 1000000 && \
     yarn cache clean
 
@@ -84,18 +84,18 @@ COPY --from=dep-version-parser /ver/.puppeteer_version /app/.puppeteer_version
 
 ARG TARGETPLATFORM
 ARG USE_CHINA_NPM_REGISTRY=0
-ARG PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1
+ARG PUPPETEER_SKIP_DOWNLOAD=1
 # The official recommended way to use Puppeteer on x86(_64) is to use the bundled Chromium from Puppeteer:
 # https://pptr.dev/faq#q-why-doesnt-puppeteer-vxxx-work-with-chromium-vyyy
 RUN \
     set -ex ; \
-    if [ "$PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" = 0 ] && [ "$TARGETPLATFORM" = 'linux/amd64' ]; then \
+    if [ "$PUPPETEER_SKIP_DOWNLOAD" = 0 ] && [ "$TARGETPLATFORM" = 'linux/amd64' ]; then \
         if [ "$USE_CHINA_NPM_REGISTRY" = 1 ]; then \
             npm config set registry https://registry.npmmirror.com && \
             yarn config set registry https://registry.npmmirror.com ; \
         fi; \
         echo 'Downloading Chromium...' && \
-        unset PUPPETEER_SKIP_CHROMIUM_DOWNLOAD && \
+        unset PUPPETEER_SKIP_DOWNLOAD && \
         yarn add puppeteer@$(cat /app/.puppeteer_version) && \
         yarn cache clean ; \
     else \
@@ -115,7 +115,7 @@ WORKDIR /app
 
 # install deps first to avoid cache miss or disturbing buildkit to build concurrently
 ARG TARGETPLATFORM
-ARG PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=1
+ARG PUPPETEER_SKIP_DOWNLOAD=1
 # https://pptr.dev/troubleshooting#chrome-headless-doesnt-launch-on-unix
 # https://github.com/puppeteer/puppeteer/issues/7822
 # https://www.debian.org/releases/bullseye/amd64/release-notes/ch-information.en.html#noteworthy-obsolete-packages
@@ -127,7 +127,7 @@ RUN \
     apt-get install -yq --no-install-recommends \
         dumb-init \
     ; \
-    if [ "$PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" = 0 ]; then \
+    if [ "$PUPPETEER_SKIP_DOWNLOAD" = 0 ]; then \
         if [ "$TARGETPLATFORM" = 'linux/amd64' ]; then \
             apt-get install -yq --no-install-recommends \
                 ca-certificates fonts-liberation wget xdg-utils \
@@ -149,7 +149,7 @@ COPY --from=chromium-downloader /app/node_modules/.cache/puppeteer /app/node_mod
 # if grep matches nothing then it will exit with 1, thus, we cannot `set -e` here
 RUN \
     set -x && \
-    if [ "$PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" = 0 ] && [ "$TARGETPLATFORM" = 'linux/amd64' ]; then \
+    if [ "$PUPPETEER_SKIP_DOWNLOAD" = 0 ] && [ "$TARGETPLATFORM" = 'linux/amd64' ]; then \
         echo 'Verifying Chromium installation...' && \
         ldd $(find /app/node_modules/.cache/puppeteer/ -name chrome -type f) | grep "not found" ; \
         if [ "$?" = 0 ]; then \

app.json

@@ -14,7 +14,7 @@
             "value": "80",
             "required": false
         },
-        "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD": {
+        "PUPPETEER_SKIP_DOWNLOAD": {
             "value": "1",
             "required": false
         }