Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): throw URL cache key #10497

Merged
merged 1 commit into from Aug 16, 2022
Merged

Conversation

TonyRL
Copy link
Collaborator

@TonyRL TonyRL commented Aug 16, 2022

该 PR 相关 Issue / Involved issue

#9347, #9461, #10163, #10438, #10440, #10472, #10473, #10423

完整路由地址 / Example for the proposed route(s)

/test/cacheUrlKey

新 RSS 检查列表 / New RSS Script Checklist

  • 新的路由 New Route
  • 文档说明 Documentation
    • 中文文档 CN
    • 英文文档 EN
  • 全文获取 fulltext
    • 使用缓存 Use Cache
  • 反爬/频率限制 anti-bot or rate limit?
    • 如果有, 是否有对应的措施? If yes, do your code reflect this sign?
  • 日期和时间 date and time
    • 可以解析 Parsed
    • 时区调整 Correct TimeZone
  • 添加了新的包 New package added
  • Puppeteer

说明 / Note

@TonyRL TonyRL removed the Route: v2 v2 route related label Aug 16, 2022
@github-actions
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/test/cacheUrlKey - Failed
HTTPError: Response code 404 (Not Found)

Route requested: /cacheUrlKey
Error message: Error: Cache key must be a string
    at Object.tryGet (/app/lib/middleware/cache/index.js:60:23)
    at module.exports (/app/lib/v2/test/index.js:79:45)
    at dispatch (/app/node_modules/koa-compose/index.js:42:32)
    at /app/node_modules/@koa/router/lib/router.js:425:16
    at dispatch (/app/node_modules/koa-compose/index.js:42:32)
    at /app/node_modules/koa-compose/index.js:34:12
    at dispatch (/app/node_modules/@koa/router/lib/router.js:430:31)
    at /app/node_modules/koa-mount/index.js:58:11
    at dispatch (/app/node_modules/koa-compose/index.js:42:32)
    at allowedMethods (/app/node_modules/@koa/router/lib/router.js:485:12)
Helpful Information to provide when opening issue:
Path: /cacheUrlKey
Node version: v16.16.0
Git Hash: ba0fbb4

@github-actions github-actions bot added the Auto: Route Test Complete Auto route test has finished on given PR label Aug 16, 2022
@TonyRL TonyRL merged commit 4877301 into DIYgod:master Aug 16, 2022
@TonyRL TonyRL deleted the core/throw-url-cache-key branch August 16, 2022 13:38
@TonyRL TonyRL added the breaking change Awww, please be careful! label Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR breaking change Awww, please be careful! core enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant