Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改进Docker的使用方式 #272

Merged
merged 3 commits into from Jun 6, 2018
Merged

改进Docker的使用方式 #272

merged 3 commits into from Jun 6, 2018

Conversation

soulteary
Copy link
Contributor

FYI.

#271

@DIYgod
Copy link
Owner

DIYgod commented Jun 6, 2018

  1. config 的问题不止 Docker 会有,感觉统一处理比较好,我稍后会优化掉,先从 config.js 读取配置,没有 config.js 时再从 config.example.js 读取

  2. app.json 是给 Heroku 使用的,应该不需要自定义

  3. package-lock.jsonyarn.lock 功能重复,这样来看还是建议统一用 yarn 比较好

  4. .prettierignore 不应该忽略 README

  5. 淘宝源国外访问非常不稳定,不建议使用,或者不应该默认使用

@soulteary
Copy link
Contributor Author

  1. 我个人使用的话,直接把项目submodule掉,然后同级一个compose file解决问题,不过参考各种开源软件的传统做法,从example config创建一个用户config来提供给用户是一个不错的选择。
  2. 我不使用heroku疏忽掉了,:(
  3. 我个人比较倾向使用npm v6 ,可参考 https://mixmax.com/blog/to-yarn-and-back-again-npm
  4. okay,这个可以去掉,改换gitkeeper吧
  5. 这个主要看compose file是给谁使用了,是国人,还是国外的人,其实一般来说会独立出.env,稍后我更新一下,把args默认设置0好了。

@DIYgod
Copy link
Owner

DIYgod commented Jun 6, 2018

是主要给国人用,但服务器在国外的可能性很大

@DIYgod DIYgod merged commit 4663a6e into DIYgod:master Jun 6, 2018
@DIYgod
Copy link
Owner

DIYgod commented Jun 6, 2018

发现引用 config 的文件很多,改动较大,先提个 issue 了 #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants