feat: add naver webtoon - #3376
Merged
Merged
Conversation
Contributor
Author
|
I added docs. |
DIYgod
requested changes
Nov 11, 2019
| const domain = 'https://comic.naver.com'; | ||
|
|
||
| async function getDescription(link) { | ||
| const { body } = await got.get(link); |
Owner
There was a problem hiding this comment.
should use cache for invariable content here, see: https://docs.rsshub.app/en/joinus/#enable-caching
Contributor
Author
There was a problem hiding this comment.
I fixed it. please check it.
DIYgod
requested changes
Nov 19, 2019
| const $ = cheerio.load(body); | ||
| return $('#comic_view_area > div.wt_viewer').html(); | ||
| result = $('#comic_view_area > div.wt_viewer').html(); | ||
| ctx.cache.set(key, result, Number.POSITIVE_INFINITY); |
Owner
There was a problem hiding this comment.
the third parameter Number.POSITIVE_INFINITY is not needed, there is a default value config.cache.contentExpire: https://github.com/DIYgod/RSSHub/blob/master/lib/middleware/cache.js#L46, controlled by external config
Number.POSITIVE_INFINITY -> config.cache.contentExpire
DIYgod
approved these changes
Dec 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://comic.naver.com