Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: FT 中文网支持繁体输出 #995

Merged
merged 22 commits into from Nov 1, 2018
Merged

Enhancement: FT 中文网支持繁体输出 #995

merged 22 commits into from Nov 1, 2018

Conversation

xyqfer
Copy link
Contributor

@xyqfer xyqfer commented Oct 28, 2018

目前有两个待确定的问题:

  • channel 参数是可选的,如果后面跟上的site 也是可选的会影响到前面的逻辑,所以暂时先用query参数(?site=big5)代替了。全局搜了下发现query参数好像只在中间件里用到,有些担心会冲突或者破坏一些先前约定什么的,这里需要请教下看看有啥更好的参数设计方案不
  • 测试的时候网络有点小坑,没能完全测试完,方便的话麻烦看下繁体输出的会不会有问题

以上

@HenryQW
Copy link
Collaborator

HenryQW commented Oct 28, 2018

@xyqfer query 不会被缓存,所以会受已有缓存影响

@DIYgod
Copy link
Owner

DIYgod commented Oct 30, 2018

可以使用一个新路由

docs/README.md Outdated
@@ -1502,6 +1502,7 @@ Category 列表:
- 不支持付费文章.
- 由于未知原因 FT 中文网的 SSL 证书不被信任 (参见[SSL Labs 报告](https://www.ssllabs.com/ssltest/analyze.html?d=www.ftchinese.com&latest)), 所有文章通过 http 协议获取.
- 由于众所周知的原因, 文章内的图片在中国大陆可能无法正常显示.
- 如需繁体可使用路由`/ft/traditional`,参数及注意事项同`/ft/chinese`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

traditional chinese 值可以合为一个 language 参数,写在参数那里会更清晰一下

@DIYgod DIYgod merged commit 717d315 into DIYgod:master Nov 1, 2018
@DIYgod
Copy link
Owner

DIYgod commented Nov 1, 2018

Merged, thanks!

@xyqfer xyqfer deleted the dev-ft-big5 branch November 1, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants