New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: FT 中文网支持繁体输出 #995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xyqfer query 不会被缓存,所以会受已有缓存影响 |
可以使用一个新路由 |
DIYgod
requested changes
Oct 31, 2018
docs/README.md
Outdated
@@ -1502,6 +1502,7 @@ Category 列表: | |||
- 不支持付费文章. | |||
- 由于未知原因 FT 中文网的 SSL 证书不被信任 (参见[SSL Labs 报告](https://www.ssllabs.com/ssltest/analyze.html?d=www.ftchinese.com&latest)), 所有文章通过 http 协议获取. | |||
- 由于众所周知的原因, 文章内的图片在中国大陆可能无法正常显示. | |||
- 如需繁体可使用路由`/ft/traditional`,参数及注意事项同`/ft/chinese` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
traditional chinese 值可以合为一个 language 参数,写在参数那里会更清晰一下
DIYgod
approved these changes
Nov 1, 2018
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
目前有两个待确定的问题:
channel
参数是可选的,如果后面跟上的site
也是可选的会影响到前面的逻辑,所以暂时先用query
参数(?site=big5
)代替了。全局搜了下发现query
参数好像只在中间件里用到,有些担心会冲突或者破坏一些先前约定什么的,这里需要请教下看看有啥更好的参数设计方案不以上