Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fps display in the progress text should better be instant ? #9

Open
ghost opened this issue Feb 16, 2021 · 6 comments
Open

fps display in the progress text should better be instant ? #9

ghost opened this issue Feb 16, 2021 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 16, 2021

Hello @DJATOM !

Currently the progress text of x265 shows important information, all calculated properly, but it seems that fps is calculated as average from the beginning:

fps = (nb of frames processed since beginning) / (time elapsed since beginning).

This gives a idea of the global behavior in the process.

However, fps is a bench-marking information. It has to reflect current status of processing speed.
Let's say, there is suddenly another process launched on the computer, then the fps should almost immediately drop. But it doesn't because the fps is a long term average here. So, I suggest:

fps = (nb of frames processed on a sliding window, or in a buffer) / (time used to process those frames)

That of course, is in my humble opinion.
And thanks always for the great work!

@ghost ghost changed the title fps display in the progress test should better be instant ? fps display in the progress text should better be instant ? Feb 16, 2021
@DJATOM
Copy link
Owner

DJATOM commented Feb 16, 2021

I personally think that average fps is more meaningful then instant. But sure, I'll consider it and probably make an option to calculate fps with different strategies.

@ghost
Copy link
Author

ghost commented Feb 16, 2021

I totally agree that all fps methods have uses and pros and cons indeed. Thanks for anything you would do 😄 !
The Kbps meter seems also global... Well maybe, it's about "instant statistics" and "global statistics" and not only fps.
Just a thought...

@Dendraspis
Copy link
Contributor

Just an idea:
The current fps would not be very useful, because it might jump a lot. But instead an additional 5min average could be nice/interesting. 🤔

@ghost
Copy link
Author

ghost commented Feb 25, 2021

@Dendraspis agreed, "pure" instant values have no use at all !
Also @DJATOM suggested that the "range" used to calculate the average can be set by the user. Personnaly I'd use a buffer of 200 or 300 frames...

However, the Total Size and Time Remaining should always use the global average values (exactly as they are currently calculated) otherwise they would be unreliable. On second thought, this is not so obvious 🤣

@ghost
Copy link
Author

ghost commented Jun 8, 2021

I have added an element of information here: Patman86/x265-Mod-by-Patman#4

Hopefully, "someone" will take a look at it 😁

@DJATOM
Copy link
Owner

DJATOM commented Jun 8, 2021

Unfortunately I don't have much time to look into that feature in few weeks or so, as I've got a load of work 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants