Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resetting path in Dataset.download #124

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Fix resetting path in Dataset.download #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/124.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug where sometimes the path wouldn't be set correctly after FITS file download.
10 changes: 5 additions & 5 deletions dkist/io/array_containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ def from_external_array_references(cls, ears, **kwargs):
Construct a collection from a (nested) iterable of
`asdf.ExternalArrayReference` objects.
"""
shape = ears[0].shape
dtype = ears[0].dtype
target = ears[0].target
ear0 = np.array(ears).flat[0]
shape = ear0.shape
dtype = ear0.dtype
target = ear0.target

for i, ele in enumerate(ears):
uris = cls._validate_homogenaity(shape, target, dtype, ears)
uris = cls._validate_homogenaity(shape, target, dtype, ears)

return cls(uris, target, dtype, shape, **kwargs)

Expand Down