Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposure Globus "label" directly to all top-level download functions #193

Merged
merged 3 commits into from Aug 4, 2022

Conversation

eigenbrot
Copy link
Contributor

@eigenbrot eigenbrot commented Jul 29, 2022

This resulted in removing the label_suffix from some intermediate functions. I
think this way is better because it gives total control to the user. The default
values have only been changed very slightly.

Fixes #184. I hope I did this right.

This resulted in removing the label_suffix from some intermediate functions. I
think this way is better because it gives total control to the user. The default
values have only been changed very slightly.
@eigenbrot eigenbrot requested a review from Cadair July 29, 2022 20:41
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #193 (c87e94a) into main (a75bf4e) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   96.26%   96.13%   -0.14%     
==========================================
  Files          29       29              
  Lines        1501     1500       -1     
==========================================
- Hits         1445     1442       -3     
- Misses         56       58       +2     
Impacted Files Coverage Δ
dkist/io/file_manager.py 95.83% <100.00%> (ø)
dkist/net/globus/transfer.py 98.36% <100.00%> (ø)
dkist/net/helpers.py 100.00% <100.00%> (ø)
dkist/io/asdf/entry_points.py 93.33% <0.00%> (-6.67%) ⬇️
dkist/io/asdf/converters/file_manager.py 92.00% <0.00%> (-4.00%) ⬇️
dkist/dataset/dataset.py 93.82% <0.00%> (-0.23%) ⬇️
dkist/net/attr_walker.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dkist/io/file_manager.py Outdated Show resolved Hide resolved
dkist/net/globus/transfer.py Outdated Show resolved Hide resolved
dkist/net/helpers.py Outdated Show resolved Hide resolved
@Cadair Cadair merged commit 6d9d91d into DKISTDC:main Aug 4, 2022
@Cadair
Copy link
Member

Cadair commented Aug 4, 2022

Thanks @eigenbrot for a lovely PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kwarg to set Globus transfer label in the call to ds.files.download and transfer_complete_datasets
2 participants