Fix slicing headers with whole axis #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 96.45% 96.62% +0.17%
==========================================
Files 37 37
Lines 2371 2372 +1
==========================================
+ Hits 2287 2292 +5
+ Misses 84 80 -4
|
Cadair
commented
Jul 21, 2023
Want to make sure the tests pass with a path that does. This reverts commit 97da297.
So many version-based problems
Cadair
commented
Jul 28, 2023
Cadair
commented
Jul 28, 2023
Cadair
commented
Jul 28, 2023
Co-authored-by: Stuart Mumford <stuart@cadair.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SolarDrew Can you add tests for this asap, because we probably shouldn't ship it if there are more hidden bugs.