Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunpy package template #347

Merged
merged 15 commits into from Mar 22, 2024
Merged

Sunpy package template #347

merged 15 commits into from Mar 22, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Mar 11, 2024

fixes #345

@Cadair Cadair marked this pull request as ready for review March 20, 2024 17:58
@Cadair Cadair requested a review from SolarDrew March 20, 2024 17:59
@Cadair
Copy link
Member Author

Cadair commented Mar 20, 2024

Once this is approved we need to change the required CI jobs.

Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm basically a layperson in this context but LGTM 👍


# Spyder project settings
.spyderproject
.spyproject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Spyder still a thing?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

@Cadair Cadair merged commit 42be752 into DKISTDC:main Mar 22, 2024
16 of 18 checks passed
@Cadair Cadair deleted the sunpy_package_template branch March 22, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt and follow the sunpy package template
3 participants