Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking tweaks #383

Merged
merged 13 commits into from
May 17, 2024
Merged

Benchmarking tweaks #383

merged 13 commits into from
May 17, 2024

Conversation

SolarDrew
Copy link
Contributor

Couple of small changes - add a non-plotting benchmark in the hope that that will prove more useful for coparisons, and only run the plotting ones twice so it doesn't take ages.

@SolarDrew
Copy link
Contributor Author

Well this hasn't made it any quicker it seems 🤔

Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #383 will improve performances by 63.93%

Comparing SolarDrew:benchmarking-codspeed (61dd540) with main (448787d)

Summary

⚡ 1 improvements
✅ 1 untouched benchmarks

🆕 1 new benchmarks
⁉️ 5 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main SolarDrew:benchmarking-codspeed Change
🆕 test_pixel_to_world N/A 2.7 s N/A
test_plot_dataset[axes0] 72.7 s 44.3 s +63.93%
⁉️ test_plot_dataset[axes1] 11 s N/A N/A
⁉️ test_plot_dataset[axes2] 14.7 s N/A N/A
⁉️ test_plot_dataset[axes3] 74.5 s N/A N/A
⁉️ test_plot_dataset[axes4] 17.3 s N/A N/A
⁉️ test_plot_dataset[axes5] 15.1 s N/A N/A

@SolarDrew SolarDrew merged commit 6f7ce1e into DKISTDC:main May 17, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant